-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply token and script fixes to sync with design #2142
base: next
Are you sure you want to change the base?
Conversation
- update outputs of sync script - add stricter checks - separate concerns (FigmaVariable should not know about style-dictionary) - updates to token values to sync with design - add properly named background-util-informational tokens - add missing background-util-warning tokens - generate tokens in output files
db5f444
to
ae1988e
Compare
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2142 +/- ##
==========================================
- Coverage 96.92% 96.89% -0.03%
==========================================
Files 114 114
Lines 2925 2935 +10
Branches 801 800 -1
==========================================
+ Hits 2835 2844 +9
- Misses 86 87 +1
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
static TIER_1_PREFIX = 'render/'; | ||
static VARIABLE_ALIAS = 'VARIABLE_ALIAS'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: a few of these constants will migrate to configuration once we have enough use cases to do so
src/tokens-dist/css/variables.css
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: all files in /tokens-dist are generated after running yarn build:tokens
or any other command that triggers this (e.g., yarn start
)
@@ -9,7 +9,7 @@ | |||
|
|||
.button { | |||
position: relative; | |||
border-radius: calc(var(--eds-border-radius-full) * 1px); | |||
border-radius: calc(var(--eds-theme-border-radius-actions) * 1px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes a bug identified during tool demo ++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm! as long as all the todo's are intended for merge then 🚢
@ajmoreno Ah good call. lemme resolve the ones with -AH in them first. I thought I got them all 😅 |
update outputs of sync script
add stricter checks
separate concerns (FigmaVariable should not know about style-dictionary)
updates to token values to sync with design
add properly named background-util-informational tokens
add missing background-util-warning tokens
generate tokens in output files
Test Plan: