Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply token and script fixes to sync with design #2142

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

booc0mtaco
Copy link
Contributor

@booc0mtaco booc0mtaco commented Mar 7, 2025

  • update outputs of sync script

  • add stricter checks

  • separate concerns (FigmaVariable should not know about style-dictionary)

  • updates to token values to sync with design

  • add properly named background-util-informational tokens

  • add missing background-util-warning tokens

  • generate tokens in output files

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

- update outputs of sync script
- add stricter checks
- separate concerns (FigmaVariable should not know about
  style-dictionary)
- updates to token values to sync with design

- add properly named background-util-informational tokens
- add missing background-util-warning tokens
- generate tokens in output files
@booc0mtaco booc0mtaco force-pushed the aholloway/EDS-1525 branch from db5f444 to ae1988e Compare March 7, 2025 19:32
Copy link

github-actions bot commented Mar 7, 2025

size-limit report 📦

Path Size
components 96.28 KB (0%)
styles 30.13 KB (+0.67% 🔺)

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.89%. Comparing base (c04326d) to head (41186ac).

Files with missing lines Patch % Lines
bin/_util.js 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2142      +/-   ##
==========================================
- Coverage   96.92%   96.89%   -0.03%     
==========================================
  Files         114      114              
  Lines        2925     2935      +10     
  Branches      801      800       -1     
==========================================
+ Hits         2835     2844       +9     
- Misses         86       87       +1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +357 to +358
static TIER_1_PREFIX = 'render/';
static VARIABLE_ALIAS = 'VARIABLE_ALIAS';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: a few of these constants will migrate to configuration once we have enough use cases to do so

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: all files in /tokens-dist are generated after running yarn build:tokens or any other command that triggers this (e.g., yarn start)

@booc0mtaco booc0mtaco requested a review from a team March 7, 2025 21:21
@@ -9,7 +9,7 @@

.button {
position: relative;
border-radius: calc(var(--eds-border-radius-full) * 1px);
border-radius: calc(var(--eds-theme-border-radius-actions) * 1px);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a bug identified during tool demo ++

Copy link

@ajmoreno ajmoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm! as long as all the todo's are intended for merge then 🚢

@booc0mtaco
Copy link
Contributor Author

@ajmoreno Ah good call. lemme resolve the ones with -AH in them first. I thought I got them all 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants