fix: don't run update-manifests for skipped prep results #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| id-token: write | ||
| contents: read | ||
| if: always() | ||
| if: always() && needs.prep.outputs.should_deploy == 'true' |
Contributor
There was a problem hiding this comment.
I think this will make it so repos that have the update-manifest job as a required check don't get a passing status unless the should_deploy is true. We use this job check to ensure ducker successfully builds even when manifests are not updated, so we want it to still run in that case
IIRC I think the issue occurs when someone merges the branch between when the prep/build jobs run and when the manifest-update job tries to checkout the branch so the fix here should catch the error when it tries to checkout the branch but it doesn't exist and gracefully exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://czi.atlassian.net/browse/CCIE-4550