fix: prioritize current frame for single-LOD case (typical volume rendering case)#667
Merged
Merged
Conversation
|
🎉 This PR is included in version 0.22.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When working with remote rendering, I noticed a bug I introduced in #665 that results in the volume layer stalling until the entire prefetch queue drains.
That PR rewrote
updateChunksForVolumeand replaced the per-chunkisCurrentLOD = chunk.lod === currentLOD_derivation with amarkVolumeChunkVisible(chunk, isFallbackLOD)helper that computesisCurrentLOD = !isFallbackLOD. WhencurrentLOD === fallbackLOD, only the current-LOD pass runs, so every chunk is marked withisFallbackLOD=false, isCurrentLOD=true.computePrioritythen returnsvisibleCurrent(priority 2 undercreatePlaybackPolicy) instead offallbackVisible(priority 0) — and sinceprefetchTimeis priority 1 in the same policy, the current frame's chunks land in the queue behind the entire prefetch backlog.This restores previous behavior by getting both
isFallbackLODandisCurrentLODfrom the chunk's ownchunk.lodinsidemarkVolumeChunkVisible, so for single LOD (we configure this typically by setting min LOD === max LOD in the policy) both flags are true andcomputePriorityreturnsfallbackVisibleas it did before #665.Tests & Checks
I confirmed this fix restores the expected (previous) behavior in a reef idetik-remote session.