Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add noindex meta tag for private collections (VC-2245) #7486

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

kaloster
Copy link
Contributor

@kaloster kaloster commented Mar 13, 2025

Reason for Change

Changes

  • Added noindex meta tag to Collection page if collection.visibility == "PRIVATE"

Testing steps

  • In rdev - inspect page source while viewing a private collecation

@kaloster kaloster requested a review from tihuan March 13, 2025 16:29
Copy link
Contributor

Deployment Summary

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (702c718) to head (40cdb9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7486   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files         194      194           
  Lines       16833    16833           
=======================================
  Hits        15666    15666           
  Misses       1167     1167           
Flag Coverage Δ
unittests 93.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kaloster kaloster force-pushed the kaloster/add-no-index branch from 40cdb9b to a3c6cdd Compare March 13, 2025 20:41
@kaloster kaloster changed the title fix: Add noindex meta tag for private collections fix: Add noindex meta tag for private collections (VC-2245) Mar 14, 2025
@kaloster kaloster merged commit a36c1b9 into main Mar 14, 2025
70 of 78 checks passed
@kaloster kaloster deleted the kaloster/add-no-index branch March 14, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants