Skip to content

fix: Style fixes rebased#1221

Merged
rainandbare merged 25 commits into
mainfrom
style-fixes-working
Jun 11, 2025
Merged

fix: Style fixes rebased#1221
rainandbare merged 25 commits into
mainfrom
style-fixes-working

Conversation

@rainandbare

@rainandbare rainandbare commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Screenshot 2025-06-09 at 4 22 34 PM

@rainandbare rainandbare changed the title fix: Style fixes fix: Style fixes rebased Jun 4, 2025
@rainandbare rainandbare requested a review from Copilot June 9, 2025 20:19

This comment was marked as outdated.

@codemonkey800 codemonkey800 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! overall lgtm, I left a few non-blocking nit comments 🫡

Comment thread client/src/common/hooks/useChromatinViewerSelectedGene.tsx Outdated
Comment thread client/src/components/BottomPanel/components/ScaleBar/ScaleBarYAxis.tsx Outdated

@tihuan tihuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Just some minor comments otherwise LGTM 😄

Please wait for Jeremy's review too 🙏 Thanks so much!

Comment thread client/src/common/hooks/useChromatinViewerData.ts
Comment thread client/src/components/BottomPanel/components/CoveragePlot/utils.ts
@tihuan tihuan requested a review from Copilot June 9, 2025 22:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors and adjusts several UI styling and naming issues across multiple components while standardizing action names and extracting shared utilities. Key changes include:

  • Consistent metric unit display in Cytoband and CoveragePlot components.
  • Updated styling for the Histogram, CellTypeDropdown, and BottomPanel components.
  • Extraction of shared utility functions and the introduction of new hooks and provider logic for chromatin viewer state management.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
client/src/components/BottomPanel/components/Cytoband/Cytoband.tsx Changed unit suffixes to lowercase to align with the formatBasePair definition.
client/src/components/BottomPanel/components/CoveragePlot/utils.ts Extracted visualization utility functions for reuse.
client/src/components/BottomPanel/components/CoveragePlot/components/Histogram/Histogram.ts Added configuration options and adjusted tick removal/retention in axis rendering.
client/src/components/BottomPanel/components/CellTypeDropdown/* Updated styling and renamed action types for consistency.
client/src/components/BottomPanel/CoveragePlot.tsx Integrated isLoading handling and refactored tooltip and color configuration.
client/src/components/BottomPanel/ChromosomeMap/ChromosomeMap.tsx Improved scrolling behavior and updated the gene selection logic.
client/src/components/BottomPanel/BottomPanel.tsx Adjusted layout styling and updated dispatch action names.
client/src/App/App.tsx Wrapped application with the new ChromatinViewerProvider.
client/src/common/hooks/useChromatinViewerSelectedGene.tsx and useChromatinViewerData.ts Introduced new hook implementations and refactored provider logic.
client/src/common/components/Embedding/* Refactored the chromatin viewer button and removed inline actions in favor of a dedicated component.
.infra/rdev/values.yaml Updated service container image tag.
Comments suppressed due to low confidence (1)

client/src/components/BottomPanel/components/ChromosomeMap/ChromosomeMap.tsx:115

  • [nitpick] The variable name 'selectedGeneInfo' is re-declared within the useEffect, shadowing a potential outer reference. Consider renaming it to something like 'geneInfo' to improve readability.
const selectedGeneInfo = getSelectedGeneInfo(selectedGeneFormatted);

Comment thread client/src/components/BottomPanel/BottomPanel.tsx Outdated
@kaloster kaloster added the stack label Jun 10, 2025
@codecov

codecov Bot commented Jun 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b22e7dd) to head (0ff2a0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1221   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tihuan tihuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!! Thanks SO much again for the outstanding work, @rainandbare 🤩 🙏 🥇 !! HURRAY!!

@rainandbare rainandbare added stack and removed stack labels Jun 10, 2025
@rainandbare rainandbare merged commit 8d9d858 into main Jun 11, 2025
38 checks passed
@rainandbare rainandbare deleted the style-fixes-working branch June 11, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants