fix: Style fixes rebased#1221
Conversation
…erg/single-cell-explorer into kaloster/optimization-part-2
…e-cell-explorer into style-fixes-working
…e-cell-explorer into style-fixes-working
codemonkey800
left a comment
There was a problem hiding this comment.
awesome work! overall lgtm, I left a few non-blocking nit comments 🫡
tihuan
left a comment
There was a problem hiding this comment.
Looks awesome! Just some minor comments otherwise LGTM 😄
Please wait for Jeremy's review too 🙏 Thanks so much!
There was a problem hiding this comment.
Pull Request Overview
This PR refactors and adjusts several UI styling and naming issues across multiple components while standardizing action names and extracting shared utilities. Key changes include:
- Consistent metric unit display in Cytoband and CoveragePlot components.
- Updated styling for the Histogram, CellTypeDropdown, and BottomPanel components.
- Extraction of shared utility functions and the introduction of new hooks and provider logic for chromatin viewer state management.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| client/src/components/BottomPanel/components/Cytoband/Cytoband.tsx | Changed unit suffixes to lowercase to align with the formatBasePair definition. |
| client/src/components/BottomPanel/components/CoveragePlot/utils.ts | Extracted visualization utility functions for reuse. |
| client/src/components/BottomPanel/components/CoveragePlot/components/Histogram/Histogram.ts | Added configuration options and adjusted tick removal/retention in axis rendering. |
| client/src/components/BottomPanel/components/CellTypeDropdown/* | Updated styling and renamed action types for consistency. |
| client/src/components/BottomPanel/CoveragePlot.tsx | Integrated isLoading handling and refactored tooltip and color configuration. |
| client/src/components/BottomPanel/ChromosomeMap/ChromosomeMap.tsx | Improved scrolling behavior and updated the gene selection logic. |
| client/src/components/BottomPanel/BottomPanel.tsx | Adjusted layout styling and updated dispatch action names. |
| client/src/App/App.tsx | Wrapped application with the new ChromatinViewerProvider. |
| client/src/common/hooks/useChromatinViewerSelectedGene.tsx and useChromatinViewerData.ts | Introduced new hook implementations and refactored provider logic. |
| client/src/common/components/Embedding/* | Refactored the chromatin viewer button and removed inline actions in favor of a dedicated component. |
| .infra/rdev/values.yaml | Updated service container image tag. |
Comments suppressed due to low confidence (1)
client/src/components/BottomPanel/components/ChromosomeMap/ChromosomeMap.tsx:115
- [nitpick] The variable name 'selectedGeneInfo' is re-declared within the useEffect, shadowing a potential outer reference. Consider renaming it to something like 'geneInfo' to improve readability.
const selectedGeneInfo = getSelectedGeneInfo(selectedGeneFormatted);
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1221 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tihuan
left a comment
There was a problem hiding this comment.
Looks fantastic!! Thanks SO much again for the outstanding work, @rainandbare 🤩 🙏 🥇 !! HURRAY!!
…e-cell-explorer into style-fixes-working
Uh oh!
There was an error while loading. Please reload this page.