feat: Update Explorer to support index by feature_id#1222
Merged
Conversation
c9cd495 to
5a2a9c7
Compare
83f1b8a to
5a2a9c7
Compare
62ad4a6 to
8fc14f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cbb9e6 to
880798e
Compare
Contributor
|
@kaloster Does this mean I can merge the delimiter PR too 👀 ? chanzuckerberg/single-cell-data-portal#7610 Thank you! |
Contributor
Author
I think we'd have to wait until 6.0 schema migration is complete for this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of GeneExpression disambiguation efforts: chanzuckerberg/single-cell-data-portal#7456
Updates:
schema.annotations.var.indexas the column for geneIdsfeature_nameis available - it will use it as the column for geneNames - if not it will just default to varIndex{ id: , name: }instead of a string to be able to utilize gene.id as the unique identifierfeature_nameas the var.index (pre 6.0 migration) or indexed withname_0(feature_id) as the var.index - post 6.0 schema.Testing