Skip to content

fix: Persist Chromatin Data info for default open state of Bottom Bar #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainandbare merged 1 commit into from
Jun 18, 2025
Merged

fix: Persist Chromatin Data info for default open state of Bottom Bar #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions client/src/common/hooks/useChromatinViewerData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect } from "react";
import { useEffect, useState } from "react";
import { useCoverageQuery } from "common/queries/coverage";
import { Schema } from "common/types/schema";
import { formatSelectedGene } from "components/BottomPanel/utils";
Expand All @@ -11,6 +11,9 @@ export function useChromatinViewerData(
const { selectedGene, genomeVersion, setGenomeVersion } =
useChromatinViewerSelectedGene();

// Track if chromatin data is available for this dataset
const [hasChromatinData, setHasChromatinData] = useState(false);

// Set genome version when schema changes
useEffect(() => {
const newGenomeVersion = getReferenceGenomeVersion(schema);
Expand All @@ -31,6 +34,12 @@ export function useChromatinViewerData(
},
});

useEffect(() => {
if (coverageQuery.data && !coverageQuery.isError) {
setHasChromatinData(true);
}
}, [coverageQuery.data, coverageQuery.isError]);

return {
isLoading: coverageQuery.isLoading,
isError: coverageQuery.isError,
Expand All @@ -42,11 +51,11 @@ export function useChromatinViewerData(
selectedGene,

// Computed values
hasValidData: Boolean(coverageQuery.data && !coverageQuery.isError),
shouldShow:
getReferenceGenomeVersion(schema) !== null &&
selectedCellTypes.length > 0 &&
Boolean(selectedGene),
Boolean(selectedGene) &&
hasChromatinData,
};
}

Expand Down
Loading