Skip to content

fix: GeneSets bug #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaloster merged 6 commits into from
Jul 9, 2025
Merged

fix: GeneSets bug #1232

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43aa267
fix: DE bug
kaloster Jul 9, 2025
3ef2abc
Fix for tests
kaloster Jul 9, 2025
9f3cbdd
chore: Updated [rdev] values.yaml image tags to sha-3ef2abc
Jul 9, 2025
1c1b9f3
Fix test 1/5
kaloster Jul 9, 2025
da493ac
Fix test 5/5
kaloster Jul 9, 2025
f531f95
chore: Updated [rdev] values.yaml image tags to sha-da493ac
Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions client/src/components/RightSideBar/components/GeneExpression/GeneExpression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,16 +99,21 @@ class GeneExpression extends React.Component<{}, State> {
const displayName = name.replace(MARKER_GENE_SUFFIX_IDENTIFIER, "");
const updatedGenes = new Map();

// find ensembl IDs for each gene in the geneset
for (const [geneName, geneData] of geneset.genes) {
const geneIdIndex = geneIds.indexOf(geneName);
const geneNameIndex = geneNames.indexOf(geneName);

const geneId = geneIds
? geneIds[geneNames.indexOf(geneName)] || ""
? geneIds[geneNameIndex] || geneIds[geneIdIndex] || ""
Comment thread
kaloster marked this conversation as resolved.
: "";

const actualGeneName =
geneIdIndex === -1 ? geneName : geneNames[geneIdIndex];
Comment thread
kaloster marked this conversation as resolved.

if (geneId) {
updatedGenes.set(geneId, geneData);
genesetIds.push(geneId);
genesetNames.push(geneName);
genesetNames.push(actualGeneName);
} else {
console.warn(`No ID found for gene: ${geneName}`);
}
Expand Down
2 changes: 1 addition & 1 deletion server/default_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
about_legal_privacy: null

presentation:
max_categories: 1000
max_categories: 30000
custom_colors: true

embeddings:
Expand Down
Loading