Skip to content

chore: SCIAPPENG-41 server/ecs/app.py: set cors for prod vcp#1355

Merged
lizmccormack merged 1 commit into
mainfrom
lizmccormack/add-prod-to-allowed-origins
Feb 5, 2026
Merged

chore: SCIAPPENG-41 server/ecs/app.py: set cors for prod vcp#1355
lizmccormack merged 1 commit into
mainfrom
lizmccormack/add-prod-to-allowed-origins

Conversation

@lizmccormack

Copy link
Copy Markdown
Contributor

Description

  • Adds production VCP URL to CORS allowed origins when DEPLOYMENT_STAGE is "prod"
  • We set staging and rdev in this PR

@lizmccormack lizmccormack requested a review from bchu1 February 4, 2026 18:19

@bchu1 bchu1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bchu1

bchu1 commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

The additional steps may be:

  1. Trigger the TF apply for prod (actually not sure if Erik did this...)
  2. Clear Cloudfront cache (Erik had to do this but not 100% sure if this is necessary to make it work)

@lizmccormack

lizmccormack commented Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

The additional steps may be:

  1. Trigger the TF apply for prod (actually not sure if Erik did this...)
  2. Clear Cloudfront cache (Erik had to do this but not 100% sure if this is necessary to make it work)

Looks like Erik already added the Origin header to the cache policy in prod and can see it in the AWS console. I’ll merge and test and clear the cache if it’s not working.

@lizmccormack lizmccormack merged commit 6c1254e into main Feb 5, 2026
32 of 34 checks passed
@lizmccormack lizmccormack deleted the lizmccormack/add-prod-to-allowed-origins branch February 5, 2026 18:15
@codecov

codecov Bot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (0684041) to head (5cd2e25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1355   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants