Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Add quotations to auto-generated rails_rbi command #310

Open
wpride wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add quotations to auto-generated rails_rbi command #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sorbet-rails/helper_rbi_formatter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def generate_rbi

@parlour.root.add_comments([
'This is an autogenerated file for Rails helpers.',
'Please rerun bundle exec rake rails_rbi:helpers to regenerate.'
'Please rerun \"bundle exec rake rails_rbi:helpers\" to regenerate.'

@hdoan741 hdoan741 Apr 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we use' 'here, you don't need to escape the ". Currently your change generate this:

       +# Please rerun \"bundle exec rake rails_rbi:helpers\" to regenerate.

But I think we only want?

       +# Please rerun "bundle exec rake rails_rbi:helpers" to regenerate.

])

@helpers.each do |helper|
Expand Down