Skip to content
This repository was archived by the owner on Jul 5, 2023. It is now read-only.

Add support for alias_attribute - #516

Open
joshuay03 wants to merge 1 commit into
chanzuckerberg:masterfrom
joshuay03:alias-attribute-support
Open

Add support for alias_attribute#516
joshuay03 wants to merge 1 commit into
chanzuckerberg:masterfrom
joshuay03:alias-attribute-support

Conversation

@joshuay03

@joshuay03 joshuay03 commented Sep 24, 2022

Copy link
Copy Markdown

Addresses #267.

Adds support for alias_attribute.

@joshuay03
joshuay03 marked this pull request as draft September 24, 2022 11:05
@joshuay03 joshuay03 changed the title Add support for alias_attribute Add support for alias_attribute Sep 24, 2022
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch 12 times, most recently from c002e39 to 5ebee82 Compare September 24, 2022 12:42
@joshuay03
joshuay03 marked this pull request as ready for review September 24, 2022 12:45
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch from 5ebee82 to 746e8c7 Compare September 24, 2022 23:34
@joshuay03
joshuay03 marked this pull request as draft September 25, 2022 00:26
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch 5 times, most recently from 553b2e3 to c1bc667 Compare September 25, 2022 09:54
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch from c1bc667 to 37d8dab Compare January 31, 2023 04:06
@joshuay03
joshuay03 marked this pull request as ready for review January 31, 2023 04:10
@codecov

codecov Bot commented Jan 31, 2023

Copy link
Copy Markdown

Codecov Report

Merging #516 (0277438) into master (447ecbe) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 0277438 differs from pull request most recent head 4082861. Consider uploading reports for the commit 4082861 to get more accurate results

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   97.48%   97.44%   -0.04%     
==========================================
  Files         115      115              
  Lines        2978     3011      +33     
==========================================
+ Hits         2903     2934      +31     
- Misses         75       77       +2     
Impacted Files Coverage Δ
...bet-rails/model_plugins/active_record_attribute.rb 98.43% <100.00%> (-1.57%) ⬇️
...odel_plugins/active_record_serialized_attribute.rb 96.96% <100.00%> (+0.30%) ⬆️
lib/sorbet-rails/model_plugins/base.rb 97.72% <100.00%> (+1.17%) ⬆️
spec/support/v5.2/sorbet_test_cases.rb 100.00% <100.00%> (ø)
spec/support/v6.0/sorbet_test_cases.rb 100.00% <100.00%> (ø)
spec/support/v6.1/sorbet_test_cases.rb 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joshuay03
joshuay03 force-pushed the alias-attribute-support branch 4 times, most recently from 9795d83 to cd458b2 Compare May 27, 2023 10:07
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch 12 times, most recently from 5817096 to 32d16ad Compare May 27, 2023 12:49
@joshuay03
joshuay03 force-pushed the alias-attribute-support branch from 32d16ad to 4082861 Compare May 27, 2023 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant