Conversation
f439dde to
20313ab
Compare
Member
Author
marudor
requested changes
Sep 29, 2017
| def print_label | ||
| @user = User.find(params[:id]) | ||
| text = "#{@user.name} #{Date.today.iso8601}" | ||
| uri = URI('http://labello/print') |
Member
Author
There was a problem hiding this comment.
So, we need a configuration file. But we need this for #5 anyway.
77e3834 to
d227b7d
Compare
e37d1a5 to
68749b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements issue #39. But perhaps this is too simple.
Do we need to configure the labello API endpoint?
Do users need to select whether something is public or private?