Optimize event processing with pipeline and fix a bug #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a Redis pipeline to batch commands for adding events. This improves performance by reducing the number of round trips to the Redis server, especially when processing a large number of events. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
pipeline-add
branch
from
e620e95 to
2529569
Compare
When pending entries existed in Redis but hadn't reached the minimum idle time, XAUTOCLAIM didn't return '0-0' as the next ID. Instead, it returned a different ID, causing the consumer to remain stuck until all recovered entries were processed, blocking new entries from being handled. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
pipeline-add
branch
from
2529569 to
e65f0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a Redis pipeline to batch commands for adding events. This improves performance by reducing the number of round trips to the Redis server, especially when processing a large number of events.
This PR also fixes a bug. When pending entries existed in Redis but hadn't reached the minimum idle time, XAUTOCLAIM didn't return '0-0' as the next ID. Instead, it returned a different ID, causing the consumer to remain stuck until all recovered entries were processed, blocking new entries from being handled.
Fixes chaoss/grimoirelab#760