Fix: explicitly invoking CMD in dockerfile#26775
Open
madhav-madhusoodanan wants to merge 1 commit intochapel-lang:mainfrom
Open
Fix: explicitly invoking CMD in dockerfile#26775madhav-madhusoodanan wants to merge 1 commit intochapel-lang:mainfrom
madhav-madhusoodanan wants to merge 1 commit intochapel-lang:mainfrom
Conversation
madhav-madhusoodanan
force-pushed
the
fix-dockerfile-issue
branch
from
d43a5d9 to
9eea8dc
Compare
Author
|
Can you please take a look @riftEmber ? I am new to this project and this is my first contribution here |
Signed-off-by: Madhav Madhusoodanan <f20200049@pilani.bits-pilani.ac.in>
madhav-madhusoodanan
force-pushed
the
fix-dockerfile-issue
branch
from
9eea8dc to
d4555ba
Compare
riftEmber
reviewed
Feb 25, 2025
Contributor
riftEmber
left a comment
riftEmber
left a comment
There was a problem hiding this comment.
Welcome, and thanks for the first contribution!
I think the comment on this CMD instruction will get out of date over time since we might not always use the debian:11 base image. I suggest either removing it, or changing it to just focus on what the CMD is for in the context of this image (launch a shell for development)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The dockerfile present at the root of the project does not have either a
CMDor anENTRYPOINTcommand.This PR fixes it.
Related Issue