Draft implementation of real(16), imag(16), complex(32)
#27010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sufficient to compile ```chapel var pi16: real(16) = 3.14159265; writeln(pi16); ``` using the C back-end --- Signed-off-by: Brad Chamberlain <[email protected]>
It seems lack of these broke some tests... maybe we do some automatic conversions between enums s.t. missing the corresponding COMPLEX enums broke things? --- Signed-off-by: Brad Chamberlain <[email protected]>
--- Signed-off-by: Brad Chamberlain <[email protected]>
…implicity --- Signed-off-by: Brad Chamberlain <[email protected]>
--- Signed-off-by: Brad Chamberlain <[email protected]>
Also add --ignore-errors for pass to the *-1.chpl version since only locking in the first error makes it equivalent to the *-2.chpl version matching its .bad file. --- Signed-off-by: Brad Chamberlain <[email protected]>
bradcray
changed the title
real(16), imag(16), complex(32)
The main thing I'm aware of that's completely busted currently is that my casts to complex rely on .re and .im which themselves currently rely on casts in order to use chpl_crealf() implemented in terms of __builtin_crealf, as I haven't found a 16-bit equivalent. This results in an infinite recursion in the compiler. I think the way to break it is to enable something like the commented-out code in chpl_anycomplex.re/.im I think there are also updates needed to the CPP_IS_LAME macros in frontend/lib/immediates/num.h, but I don't quite follow the second of these yet. --- Signed-off-by: Brad Chamberlain <[email protected]>
|
A place where this PR is currently failing comes up with a simple test case like: var c32: complex(32);
var r = c32.re;Specifically, my current implementation implements the |
Thanks to Jade for the tip about __builtin_crealf() working for complex(32) (though I have no intuition as to why that would be...) --- Signed-off-by: Brad Chamberlain <[email protected]>
--- Signed-off-by: Brad Chamberlain <[email protected]>
--- Signed-off-by: Brad Chamberlain <[email protected]>
--- Signed-off-by: Brad Chamberlain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a work in progress to try and add support for 16-bit floats, such as
real(16),imag(16), andcomplex(32)for platforms and back-end compilers that support_Float16.TODO:
_Float16(like our CI's compiler, apparently)