Get dyno resolving array slicing #27024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifthpe
force-pushed
the
array-slicing
branch
3 times, most recently
from
be684fa to
7e45e77
Compare
arifthpe
force-pushed
the
array-slicing
branch
3 times, most recently
from
6b9264b to
41c607f
Compare
arifthpe
changed the title
This reverts commit 6f43710. Signed-off-by: Anna Rift <[email protected]>
Includes a test for multi-dim indexing with varargs Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few missing pieces for dyno resolution of array slicing module code, and add testing of it.
This just required adding some branches to
arrayTypeFromSubsHelper, and fixing a bug in resolvingthiscalls on the dot expression_array.domain.Resolves https://github.com/Cray/chapel-private/issues/7259.
This depends on #27102 to pass spectests (but is not rebased off of it), so that should be merged first.
[reviewer info placeholder]
Testing:
release/examples/spec/Arrays/slicing