Skip to content

Improve errors for invalid files in Image module #27067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 8, 2025

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented Apr 7, 2025

Improve the errors generated by the Image module when reading an incorrect/invalid file.

This PR also adjusts a few halts in throwing functions to throw catchable errors, rather halting.

  • start_test test/library/packages/Image/

[Reviewed by @ShreyasKhandekar]

Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
@ShreyasKhandekar ShreyasKhandekar self-requested a review April 7, 2025 23:57
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Copy link
Contributor

@ShreyasKhandekar ShreyasKhandekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Some of these errors can use more specific types like IllegalArgumentError for unsupported types.

@jabraham17 jabraham17 merged commit 6d468c3 into chapel-lang:main Apr 8, 2025
10 checks passed
@jabraham17 jabraham17 deleted the improve-image-errors branch April 8, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants