Emit a dSYM archive on MacOS with C backend #27101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
dlongnecke-cray
approved these changes
Apr 11, 2025
| ifeq ($(COMP_GEN_DEBUG),1) | ||
| ifeq ($(CHPL_MAKE_TARGET_PLATFORM),darwin) | ||
| ifneq ($(CHPL_MAKE_TARGET_COMPILER),llvm) | ||
| rm -f $(BINNAME) |
There was a problem hiding this comment.
Should we touch these things first to make sure they exist?
There was a problem hiding this comment.
I don't think that is needed. This is the same logic that was there before, -f meaning that rm won't fail if the file doesn't exist
There was a problem hiding this comment.
Ohp my bad I completely glanced over the -f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the Chapel executable Makefiles to invoke dsymutil on MacOS when debugging information is requested. This is only done when the target compiler is not LLVM, as the Chapel compiler already handles this case for LLVM.
This improves the generated debug symbols on MacOS when using the C backend, without needing to save the generated C files
This PR builds on the work in #24436
[Reviewed by @dlongnecke-cray]