Add missing const qualifiers from char* declarations
#27104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code here is longstanding, but has recently started getting tested in GASNet's test configurations as a result of chapel-lang#26236, which makes greater use of slurm by default. They compile in developer mode to get maximal errors and warnings, and that tripped a warning for some `char* ... = "literal";` declarations that should've been `const char*`. This suggests that we should potentially be dialing up warnings in our own nightly testing, which is somewhat thematically related to Cray/chapel-private#3138 --- Signed-off-by: Brad Chamberlain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code here is longstanding, but has recently started getting tested in GASNet's test configurations as a result of #26236, which makes greater use of slurm by default. They compile in developer mode to get maximal errors and warnings, and that tripped a warning for some
char* ... = "literal";declarations that should've beenconst char*.This suggests that we should potentially be dialing up warnings in our own nightly testing, which is somewhat thematically related to https://github.com/Cray/chapel-private/issues/3138