Drop support for LLVM 11, 12, and 13#27326
Merged
jabraham17 merged 9 commits intochapel-lang:mainfrom Jul 2, 2025
Merged
Conversation
jabraham17
force-pushed
the
drop-llvm-11-12-13
branch
from
86cd835 to
4046ddd
Compare
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
jabraham17
force-pushed
the
drop-llvm-11-12-13
branch
from
4046ddd to
b0d0fab
Compare
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
arifthpe
requested changes
Jul 2, 2025
Collaborator
arifthpe
left a comment
arifthpe
left a comment
There was a problem hiding this comment.
Grepping for things like "LLVM" + {11,12,13,14}, "HAVE_LLVM_VER" + {110,120,130,140}, etc, I found these additional locations that also need updating:
- make/compiler/Makefile.gnu:381
- make/compiler/Makefile.clang:188
- compiler/llvm/llvmUtil.cpp:823
- frontend/include/chpl/util/clang-integration.h:58
- frontend/lib/util/filesystem.cpp:252
- frontend/lib/parsing/parsing-queries.cpp:948
- util/devel/test/portability/vagrant/current/generic-x32-debian12/Vagrantfile:16 (the provision script installing LLVM will need to be pinned to a newer version)
- util/chplenv/chpl_llvm.py:1260
- compiler/include/llvmVer.h:42
- util/cron/common-llvm.bash:28
- doc/rst/usingchapel/prereqs.rst
Member
Author
|
Making a checklist for the items in #27326 (review)
|
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Collaborator
|
Btw, probably don't need to worry about actually running the portability tests after updating the provision script. It's possible the version-pinned packages will exist in some distros but not others, but that'll be easy to catch and fix when testing during the next release cycle. |
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
arifthpe
approved these changes
Jul 2, 2025
Collaborator
arifthpe
left a comment
arifthpe
left a comment
There was a problem hiding this comment.
LGTM after nitpick and a fresh make check run
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Member
Author
|
A fresh |
2 tasks
arifthpe
added a commit
that referenced
this pull request
Jul 16, 2025
Previously we relied on system LLVM (11) on Amazon Linux 2, as the default GCC is too old to build LLVM. However, after dropping support for LLVM 11 in #27326, this is no longer an option. Update the build process for Amazon Linux 2 to install the available `gcc10` package, and set `CC` and `CXX` so it will be used during Chapel build. Also update `prereqs.rst` to reflect this. Additionally, since this will enable building with `CHPL_LLVM=none`, add a `-nollvm` variant of the `amazonlinux-2` apptainer portability testing configuration. While here, update the path to the `extract-docs.py` script referenced in `prereqs.rst`, which was moved in #27398. [reviewed by @jabraham17, thanks!] Testing: - [x] locally testing LLVM and no-LLVM configs (in Docker) works - [x] locally generated docs look right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops support for LLVM 11, 12, and 13
Resolves #27269
make checkwith LLVM 14[Reviewed by @arifthpe]