Convert the code snippets in some standard modules to tests#27491
Convert the code snippets in some standard modules to tests#27491dlongnecke-cray merged 4 commits intochapel-lang:mainfrom
Conversation
|
Huh, not sure what to make of those failing CI checks. |
dlongnecke-cray
force-pushed
the
make-docs-testable-4
branch
from
e967502 to
b771b8d
Compare
dlongnecke-cray
force-pushed
the
make-docs-testable-4
branch
from
b771b8d to
b9b1d47
Compare
David and I talked about this on slack, likely this is due to |
dlongnecke-cray
force-pushed
the
make-docs-testable-4
branch
from
1e8da61 to
1f17ba6
Compare
lydia-duncan
left a comment
lydia-duncan
left a comment
There was a problem hiding this comment.
One minor thing to fix, one question that I have. Thanks for taking this on!
|
|
||
| /* START_EXAMPLE_2 */ | ||
| // (optional) if we counted previously, reset the counters to zero | ||
| resetCommDiagnostics(); |
There was a problem hiding this comment.
Should there be a resetCommDiagnostics call in between STOP_EXAMPLE_0 and START_EXAMPLE_1? Or is that unnecessary since we did a Here call instead?
|
Thanks for the feedback. I got distracted and sat on this for awhile and let it get stale. Rebasing and addressing your comments now. |
|
No worries, there's a lot going on :) |
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
Signed-off-by: David Longnecker <dlongnecke-cray@users.noreply.github.com>
dlongnecke-cray
force-pushed
the
make-docs-testable-4
branch
from
1f17ba6 to
6c0b61f
Compare
|
Just rebased and pushed fixes in response to your feedback. |
|
@lydia-duncan I took the liberty of merging while it's still Thursday, hope you're OK with that. |
|
Yeah, that was the right call! |
3 participants
Convert the code snippets in a bunch more standard modules to testable examples.
Reviewed by @lydia-duncan. Thanks!