Merged
Conversation
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
Vaguely, this prevents infinite recursion (see comment in commit). More specifically, the recursion is also addressed by an `isQueryRunning`, but `isQuerryRunning` literally poisons memoized queries, so this workaround effectively avoids computing / caching its result. Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
Signed-off-by: Danila Fedorin <daniel.fedorin@hpe.com>
6915955 to
a3ab1b6
Compare
benharsh
approved these changes
Aug 5, 2025
| // This dependency is technically broken anyway by uses of isQueryRunning, | ||
| // but I'm keeping this workaround since isQueryRunning technically violates | ||
| // the "no side effects" rule of queries, so the fewer queries end up | ||
| // invoking it, the better. -D.F. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Cray/chapel-private/issues/7401.
Specifically, this PR properly handles calls to methods that are the scalar type" of another type. E.g., this makes it possible to invoke a method on each element of an array or records/classes. Sample code from #7401:
Testing
types/atomic/sungeun/atomic_varscompiles with--dyno-resolve-only -comp-only--dyno-resolve-onlyReviewed by @benharsh -- thanks!