Fix error code being divided by 256 in testRelease script#27580
Merged
arifthpe merged 2 commits intochapel-lang:mainfrom Aug 5, 2025
Merged
Fix error code being divided by 256 in testRelease script#27580arifthpe merged 2 commits intochapel-lang:mainfrom
testRelease script#27580arifthpe merged 2 commits intochapel-lang:mainfrom
Conversation
Member
|
It's not entirely clear to me why anything would need to be done with the error code rather than just printing it out. Is it to you? That said, what you have here is no worse than what we had (and is arguably strictly better), so I'm OK with proceeding with it. |
Collaborator
Author
|
This mod ensures that the status code is in the usual range [0,256) . I'm not sure if that range limitation comes from POSIX or Linux or bash or something else. I'm pretty sure an out of range error code will just get modded like this by the invoking shell anyways. Not to mention we probably wouldn't have an out of range code returned by whatever other script of ours this invokes. I guess we might as well not do the mod and find out. |
Signed-off-by: Anna Rift <anna.rift@hpe.com>
Signed-off-by: Anna Rift <anna.rift@hpe.com>
3d4113c to
fce97be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove an instance of a command status code being divided by 256 in
util/buildRelease/testRelease.I think this was likely intended to be modded to ensure the status code returned is in the typical 0-255 range. But even that may not be necessary since we just shouldn't be returning an out of range error code from whatever other script of ours this invokes anyways.
[reviewer info placeholder]