Attempt to fix the whiteboxes, again#27608
Merged
lydia-duncan merged 1 commit intochapel-lang:mainfrom Aug 6, 2025
Merged
Conversation
Instead of loading the normal base dependencies and unloading llvm, load a new base dependencies script I've created specially for the whiteboxes that doesn't include llvm from the start. I'm doing this in case something about trying to load that llvm version is what is throwing off the CC computation for whitebox testing ---- Signed-off-by: Lydia Duncan <lydia-duncan@users.noreply.github.com>
arifthpe
approved these changes
Aug 6, 2025
Collaborator
arifthpe
left a comment
arifthpe
left a comment
There was a problem hiding this comment.
Worth a try, I think loading LLVM sets CC and CXX, and maybe unloading unsets those vars rather than restoring their previous values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[reviewed by @arifthpe]
Instead of loading the normal base dependencies and unloading llvm, load a new base dependencies script I've created specially for the whiteboxes that doesn't include llvm from the start. I'm doing this in case something about trying to load that llvm version is what is throwing off the CC computation for whitebox testing