Add skipifs for tests that require more locales than we have available#27612
Merged
e-kayrakli merged 1 commit intochapel-lang:mainfrom Aug 6, 2025
Merged
Add skipifs for tests that require more locales than we have available#27612e-kayrakli merged 1 commit intochapel-lang:mainfrom
e-kayrakli merged 1 commit intochapel-lang:mainfrom
Conversation
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some tests in
release/examples/primersthat require more than 4 locales. However, after recent changes in our datacenter, a GPU config has been moved to a partition with 4 locales. This PR skips those tests in GPU configs.Alternatively, we could skip those tests if the
CHPL_LAUNCHER_PARTITIONvariable is set to a specific value. That sounded more principled, but would have made the skipif more niche and harder to find. With this PR, we skip those tests based onCHPL_LOCALE_MODELinstead.Test:
--respect-skipifs