Add a nice warning when LLDB does not support Python#27616
Merged
jabraham17 merged 6 commits intochapel-lang:mainfrom Aug 7, 2025
Merged
Add a nice warning when LLDB does not support Python#27616jabraham17 merged 6 commits intochapel-lang:mainfrom
jabraham17 merged 6 commits intochapel-lang:mainfrom
Conversation
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
DanilaFe
reviewed
Aug 7, 2025
Comment on lines
159
to
167
| static chpl_bool chpl_lldb_supports_python(void) { | ||
| char output[256]; | ||
| const char* command = "lldb --version"; | ||
| if (!chpl_get_command_output(command, output, sizeof(output))) { | ||
| return false; | ||
| } | ||
| return output[0] != '\0' && access(output, R_OK) == 0; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I'm not sure why just running lldb --version tells you if "LLDB supports Python". Doesn't it just confirm that LLDB is installed? What am I missing?
Member
Author
There was a problem hiding this comment.
Thats a very silly typo, it should be --python-path
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
DanilaFe
approved these changes
Aug 7, 2025
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
DanilaFe
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a nicer error when LLDB does not support Python
Also fixes a few nightly tests that failed with errors about LLDB missing Python support
start_test test/execflags/lldbddash/declint.chpl test/library/standard/Debugger/breakpoint/useBreakpoint-lldb.chpl test/llvm/debugInfo/lldb/targetVar.chpl[Reviewed by @DanilaFe]