Avoid homebrew issues with gasnet saving homebrew shim#27626
Merged
jabraham17 merged 1 commit intochapel-lang:mainfrom Aug 11, 2025
Merged
Avoid homebrew issues with gasnet saving homebrew shim#27626jabraham17 merged 1 commit intochapel-lang:mainfrom
jabraham17 merged 1 commit intochapel-lang:mainfrom
Conversation
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
arifthpe
approved these changes
Aug 11, 2025
jabraham17
added a commit
that referenced
this pull request
Aug 12, 2025
Ignore errors when GASNET_INC_MAKEFILE is missing. This should only occur when someone explicitly deletes a gasnet include makefile, like in the homebrew formula (see #27626). #27626 removed the gasnet include makefiles because they hardcode an incorrect compiler path from homebrew. This is fine, because once Chapel is built those makefiles aren't needed. But they are needed to run `make check`, which `brew test chapel` will run [Reviewed by @arifthpe]
arifthpe
added a commit
to arifthpe/homebrew-core
that referenced
this pull request
Sep 19, 2025
arifthpe
added a commit
to arifthpe/homebrew-core
that referenced
this pull request
Sep 19, 2025
6 tasks
arifthpe
added a commit
to arifthpe/homebrew-core
that referenced
this pull request
Sep 26, 2025
Apply the following improvements/fixes from upstream releases 2.5 and 2.6: - chapel-lang/chapel#26937 - chapel-lang/chapel#27535 - chapel-lang/chapel#27546 - chapel-lang/chapel#27564 - chapel-lang/chapel#27626 - chapel-lang/chapel#27653 Additionally, disable gasnet+smp build and test on linux/arm64 to work around an as yet undiagnosed build failure on the platform. Includes a hack to allow gasnet+smp checkChplInstall testing to succeed on a system with less than 4 cores, to be removed once there's an upstream fix. Adds a requirement of arm64 arch on macOS, as we've encountered portability issues with gasnet+smp on x86_64 macOS 14, which we don't have the time to fix at the moment and aren't worth denying the feature to other platforms over.
arifthpe
added a commit
to arifthpe/homebrew-core
that referenced
this pull request
Sep 26, 2025
Apply the following improvements/fixes from upstream releases 2.5 and 2.6: - chapel-lang/chapel#26937 - chapel-lang/chapel#27535 - chapel-lang/chapel#27546 - chapel-lang/chapel#27564 - chapel-lang/chapel#27626 - chapel-lang/chapel#27653 - chapel-lang/chapel#27865
6 tasks
jabraham17
added a commit
to jabraham17/homebrew-core
that referenced
this pull request
Oct 7, 2025
Apply the following improvements/fixes from upstream releases 2.5 and 2.6: - chapel-lang/chapel#26937 - chapel-lang/chapel#27535 - chapel-lang/chapel#27546 - chapel-lang/chapel#27564 - chapel-lang/chapel#27626 - chapel-lang/chapel#27653 - chapel-lang/chapel#27865 Addresses feedback given in Homebrew#244962 Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent PR to add gasnet to the homebrew formula broke some homebrew audits, because gasnet is storing some homebrew internal paths. Since we don't make use of those files in homebrew anyways, we can just remove them
[Reviewed by @arifthpe]