28099 feat unittest assertclose #28144
Conversation
… array types, using overloaded proc. Attempted simple test. UnitTests (AssertClose, AssertEquals, AssertTrue) failing with: $CHPL_HOME/modules/packages/UnitTest.chpl:203: internal error: unsupported case in resolveTypeAlias [resolution/functionResolution.cpp:10430] > Note: This source location is a guess.
… error, but getting rid of invalid where clause (ruling that out), adding void return type
…ng point! making params param proc fixed issue. relax exact domain matching in the future
…ut different indexing allowed,add additional tests. withinTol made generic. fixed printing for complex numbers
|
@e-kayrakli I still need to rebase, but wanted your feedback on current progress so far, especially whether or not this is following best practices. Logic-wise though, I required array shapes to match as assertEqual throws an error for that, figured we could stay consistent for now? Or we could allow 1D and multidimensional array comparisons if sizes match? Can't think of an application for that but let me know. Also, I throw a generic Probably need more thorough tests/better documentation too. |
|
Thanks @jmag722! On a quick look the direction looks right to me. Just a few procedural caveats:
We can still work on the PR and I can test and help you test it next week. If we agree that it is ready to go, we can add a post-release label to it and I can merge it in once the release dust settles. In which case, this feature will be in version 2.8 due roughly in 3 months. |
|
Thanks! Oh good to know. There's no rush on this, we can talk more next week. |
2 participants
Adding assertClose method to UnitTest, for comparing real/complex scalars and arrays against an expected value.