Add support for ROCm 6.3#28220
Conversation
| MIN_ROCM6_REQ_VERSION = "6.0" | ||
| MAX_ROCM6_REQ_VERSION = "6.3" # upper bound non-inclusive | ||
| MAX_ROCM6_REQ_VERSION_NICE = "6.2.x" | ||
| MAX_ROCM6_REQ_VERSION = "6.4" # upper bound non-inclusive |
There was a problem hiding this comment.
Semi serious question: Should we drop upper bounds here and let people try whatever version they might want to? Looking at the diff here, the only real "fix" here is this bump it looks like. Are we unnecessarily creating work for us to bump this up for each ROCm version?
There was a problem hiding this comment.
I would not be that opposed to removing the upper bound. I think it is a nicer user experience that users can only use Chapel with known-to-work versions, rather than getting build/runtime errors. However, its a maintenance burden and can also frustrate users.
Maybe a good compromise is to turn it into a warning?
There was a problem hiding this comment.
I've changed the error into a warning, let me know what you think
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
e-kayrakli
left a comment
There was a problem hiding this comment.
Any particular reason to add testing for 6.3 specifically instead of bumping the version of the existing config? I am not against it at all, just curious.
|
I am doing that because of the "degraded" state ROCm 6.3 is in with bad halts and I wanted to maintain testing for the old version |
|
Woohoo! |
Adds support for using Chapel with ROCm 6.3.
This PR does not resolve the issue with halting described in #26934, rather it just assumes it to be an acceptable error message.
start_test test/gpu/nativewithCHPL_GPU=amdstart_test test/gpu/nativewithCHPL_GPU=amdandCHPL_COMM=ofiResolves #26934
I have opened #28415 to capture the desire for better ROCm crashes
[Reviewed by @e-kayrakli]