Fix uniquifyName failure when compiling with debug flag #28258
+113
−91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where we were erroneously throwing an internal error when calling
uniquifyNamewhen--debug-safe-optimizations-onlywas passed.I narrowed this down to being caused by
--no-copy-propagation --no-dead-code-eliminationleaving behind multiple extern declarations with the same name in a single function. This failure is caused by the compiler leaving extra temporaries behind, but the bug is actually just #9299, so I just fixed #9299.I also found a failure when using
remove-empty-recordsby itself, which I fixed in this PR.Resolves #28165
Resolves #9299
--debug-safe-optimizations-onlynow compiles