Adjust the runtime build output directory to use absolute paths #28359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was using relative paths before e.g., '../lib/...', but this causes problems when building the runtime as a dynamic library on my feature branch. Stop doing that. Signed-off-by: David Longnecker <[email protected]>
Signed-off-by: David Longnecker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the runtime library to be output using an absolute path.
The dynamic loading effort currently requires the runtime to be built as a dynamic library. I was having problems doing that on Mac because
dyldbakes in the load path using the-oname of the binary, which prior to this PR was a relative path e.g,.../lib/<cfg-path>/libchpl.so. Adjust the Makefiles to stop doing that and use an absolute path instead via$(CHPL_MAKE_HOME).