Skip to content

feat: fingerprint queries by connection pool db config #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
segiddins wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: fingerprint queries by connection pool db config #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/prosopite.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def scan
tc[:prosopite_query_counter] = Hash.new(0)
tc[:prosopite_query_holder] = Hash.new { |h, k| h[k] = [] }
tc[:prosopite_query_caller] = {}
tc[:prosopite_query_db_config] = {}

@allow_stack_paths ||= []
@ignore_pauses ||= false
Expand Down Expand Up @@ -97,7 +98,8 @@ def resume

def scan?
!!(tc[:prosopite_scan] && tc[:prosopite_query_counter] &&
tc[:prosopite_query_holder] && tc[:prosopite_query_caller])
tc[:prosopite_query_holder] && tc[:prosopite_query_caller] &&
tc[:prosopite_query_db_config])
end

def finish
Expand All @@ -111,6 +113,7 @@ def finish
tc[:prosopite_query_counter] = nil
tc[:prosopite_query_holder] = nil
tc[:prosopite_query_caller] = nil
tc[:prosopite_query_db_config] = nil
end

def start_raise
Expand All @@ -134,9 +137,10 @@ def create_notifications

tc[:prosopite_query_counter].each do |location_key, count|
if count >= @min_n_queries
db_config = tc[:prosopite_query_db_config][location_key]
fingerprints = tc[:prosopite_query_holder][location_key].group_by do |q|
begin
fingerprint(q)
fingerprint(q, db_config: db_config)
rescue
raise q
end
Expand All @@ -159,8 +163,8 @@ def create_notifications
end
end

def fingerprint(query)
db_adapter = ActiveRecord::Base.connection_db_config.adapter
def fingerprint(query, db_config:)
db_adapter = db_config.adapter
if db_adapter.include?('mysql') || db_adapter.include?('trilogy')
mysql_fingerprint(query)
else
Expand Down Expand Up @@ -273,12 +277,12 @@ def subscribe
return if @subscribed

ActiveSupport::Notifications.subscribe 'sql.active_record' do |_, _, _, _, data|
sql, name = data[:sql], data[:name]
sql, name, connection = data[:sql], data[:name], data[:connection]

if scan? && name != "SCHEMA" && sql.include?('SELECT') && data[:cached].nil? && !ignore_query?(sql)
query_caller = caller_locations
# Calculate the location key with as few allocations as possible
location_key = [].tap do |array|
location_key = [connection.pool.db_config].tap do |array|
query_caller.each do |loc|
array << loc.path
array << loc.lineno
Expand All @@ -287,6 +291,7 @@ def subscribe

tc[:prosopite_query_counter][location_key] += 1
tc[:prosopite_query_holder][location_key] << sql
tc[:prosopite_query_db_config][location_key] = connection.pool.db_config

if tc[:prosopite_query_counter][location_key] > 1
tc[:prosopite_query_caller][location_key] = query_caller
Expand Down