Split into library and executable #60
Conversation
| return packet | ||
|
|
||
|
|
||
| def encode_file(fhandle=stdin, chunksize=2048, compresslevel=5, |
There was a problem hiding this comment.
It is not necessary to deal with this for #60, however at some point, we should check if fhandle is bytes or bytearray, in which case we should use it as data rather than opening it as a handle.
| del gzip_compress, gzip_decompress | ||
|
|
||
|
|
||
| def warn(integer, *argv, **kwargs): |
There was a problem hiding this comment.
This does not need to be handled for #60, but in the long run, we should probably use python's logging library. When we started with Bitshuffle, it was sufficiently small that logging would be overkill, but at this point, we want to make sure we aren't polluting other developer's output streams.
| def decode(message): | ||
| '''Decode any number of packets previously encoded with bitshuffle | ||
| Assumes all packets are part of the same message''' | ||
| _, _, _, compression, seq_num, \ |
There was a problem hiding this comment.
This is very nitpicky, and not really related to #60, but these variables names do not make it obvious that these values are indicies. Reading file_hash, you would expect the variable to hold the hash, not the index thereof.
I think it's been like this for a while, but it just occurred to me.
Closes #54. Should make #39 much easier to implement. Gets #55 slightly closer to completion.
Highlights:
Minor changes:
shashumglobally toshasumNote: anything imported in
__init__.pyis accessible programmatically