fix(stopwatch): initialize Interval field with default 1s#903
Open
JesterSe7en wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(stopwatch): initialize Interval field with default 1s#903JesterSe7en wants to merge 1 commit intocharmbracelet:mainfrom
JesterSe7en wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #862
Description:
The New() function was documented to default to a 1s interval, but it was initializing with a 0 duration
Changes:
Initialized Interval to time.Second in the New function.
Took the liberty to create stopwatch_test.go to verify the default value and ensure WithInterval still works correctly.
This is my first-ever contribution to open source! So please let me know if there are any style adjustments or changes you'd like me to make.
CONTRIBUTING.md.