fix textinput: render full placeholder text#955
Open
Jah-yee wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix textinput: render full placeholder text#955Jah-yee wants to merge 1 commit intocharmbracelet:mainfrom
Jah-yee wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Previously, the placeholder would only display the first character when Width() was small or unset. This was caused by allocating a rune slice with size m.Width()+1, which would truncate the placeholder text. Now we allocate the full placeholder text and display it properly regardless of the Width() setting. Fixes charmbracelet#779
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
I noticed this bug where the placeholder only shows the first character when Width() is small or unset.
The issue is in the placeholderView() function - it allocates a rune slice with size m.Width()+1, which truncates the placeholder text when Width() is 0 or not set.
Fix
Allocate the full placeholder text directly instead of truncating it based on Width().
Testing
This fix should allow the full placeholder text ("Nickname", "Email", "Password") to display properly regardless of the Width() setting.
Thank you for your work on this project. I hope this small fix is helpful. Please let me know if there's anything to adjust.
Warmly, RoomWithOutRoof