fix(filepicker): render after default-height navigation#963
Open
lawrence3699 wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix(filepicker): render after default-height navigation#963lawrence3699 wants to merge 1 commit intocharmbracelet:mainfrom
lawrence3699 wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #864.
When a filepicker is used before Bubble Tea sends a
WindowSizeMsg, it starts withHeight() == 0. The initial view can still show the first entry, but opening a child directory resetsmaxIdxto-1, soView()filters out every entry and returns an empty string even when files exist.This sets the default height to
1, matching the issue workaround, so navigation keeps one visible row untilAutoHeightapplies the terminal height. The regression test opens a temp child directory with the default height and verifies that the file inside remains visible.Validation:
go test ./filepickergo test ./...go build ./...go test -race ./filepickergo run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.9.0 run ./filepicker