feat(examples): tree #1190
Open
feat(examples): tree #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, man. Do you mind re-opening this against |
|
No worries, will do |
caarlos0
approved these changes
Dec 3, 2024
dlvhdr
force-pushed
the
dlvhdr/tree-example
branch
from
4856dfc to
9568bd7
Compare
caarlos0
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @dlvhdr,
Thanks for writing these examples!
- Can you rebase your branch with
v2-expand squash your commits into a single one? - Can you ensure that CI passes for tests and lint?
- We might need to temporarily pin the last commits from feat: tree bubble bubbles#639 and feat(tree): support width and indenter styling lipgloss#446 (after addressed) to make the CI pass.
- (Before merging this PR, these two others should be merged first and we'll to update again to point to
v2-expof each project).
- (Before merging this PR, these two others should be merged first and we'll to update again to point to
- I made a couple of comments for small improvements on the examples.
dlvhdr
force-pushed
the
dlvhdr/tree-example
branch
from
bc898b1 to
58c9b48
Compare
fix: comments
dlvhdr
force-pushed
the
dlvhdr/tree-example
branch
from
58c9b48 to
0e6de87
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2-exp #1190 +/- ##
=========================================
Coverage ? 46.54%
=========================================
Files ? 26
Lines ? 1781
Branches ? 0
=========================================
Hits ? 829
Misses ? 886
Partials ? 66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+47
to
+50
|
|
||
| replace github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1 => ../../lipgloss | ||
|
|
||
| replace github.com/charmbracelet/bubbles/v2 v2.0.0-beta.1 => ../../bubbles |
There was a problem hiding this comment.
Comment on lines
+124
to
+129
| t.AdditionalShortHelpKeys = func() []key.Binding { | ||
| return kb | ||
| } | ||
| t.AdditionalFullHelpKeys = func() []key.Binding { | ||
| return kb | ||
| } |
There was a problem hiding this comment.
You'll need to update these two because of charmbracelet/bubbles#639 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.