Skip to content

Conversation

@andreynering
Copy link
Member

@andreynering
Copy link
Member Author

andreynering commented Feb 4, 2025

So... I just discovered that multiple %w are only supported starting on Go 1.20:

$ env GOTOOLCHAIN=go1.19 go test ./...
go: downloading go1.19 (darwin/arm64)
# github.com/charmbracelet/bubbletea
./tea.go:625:9: fmt.Errorf call has more than one error-wrapping directive %w
FAIL	github.com/charmbracelet/bubbletea [build failed]
FAIL
$ env GOTOOLCHAIN=go1.20 go test ./...
go: downloading go1.20 (darwin/arm64)
ok  	github.com/charmbracelet/bubbletea	0.302

By our CI failures and go.mod, it looks like we're still supposed to support 1.18 and 1.19. I think we can just keep this PR open until we move to Go 1.20 as a minimum requirement.

@desertwitch
Copy link
Contributor

Resolved with #1376, #1388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

context error is swallowed up, preventing errors.Is

4 participants