Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to the project.
I was impresse of how powerful and rich the charm ecosystem is. I used for one of my toy projects https://github.com/GustavoCaso/expensetrace/tree/main/internal/cli/tui
I decided to have a look at the code of bubbletea to understand better how it works internally. I noticed that is some parts of the code it uses
p.startupOptions.has
and in others usesp.startupOptions&
.I thought it would be a good first contribution to update the code to use
has
in all cases that is checkingp.startupOptions
Look forward for any feedback 😉