Skip to content

(v2) tea.go: deadlock/error return fixes, additional tests (targeted at v2) #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: v2-exp
Choose a base branch
from

Conversation

desertwitch
Copy link

@desertwitch desertwitch commented Apr 13, 2025

This PR contains the v2-targeted and v2-applicable portions of the following v1-targeted fixes:

Meaning it fixes all above issues in v2, the bugs that are not already resolved otherwise in v2.
Issues are related to deadlocks and wrongful nil returns on error, PR adds a couple of tests as well.

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (v2-exp@7858a14). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tea.go 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v2-exp    #1388   +/-   ##
=========================================
  Coverage          ?   47.95%           
=========================================
  Files             ?       26           
  Lines             ?     1810           
  Branches          ?        0           
=========================================
  Hits              ?      868           
  Misses            ?      877           
  Partials          ?       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants