Skip to content

added forbidigo linter and allow two printf calls #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dennyreeh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added forbidigo linter and allow two printf calls #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ linters:
enable:
- bodyclose
- exhaustive
- forbidigo
- goconst
- godot
- gomoddirectives
Expand Down
6 changes: 3 additions & 3 deletions tea.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,8 +842,8 @@ func (p *Program) recoverFromPanic(r interface{}) {
case p.errs <- ErrProgramPanic:
default:
}
p.shutdown(true) // Ok to call here, p.Run() cannot do it anymore.
fmt.Printf("Caught panic:\n\n%s\n\nRestoring terminal...\n\n", r)
p.shutdown(true) // Ok to call here, p.Run() cannot do it anymore.
fmt.Printf("Caught panic:\n\n%s\n\nRestoring terminal...\n\n", r) //nolint:forbidigo
debug.PrintStack()
}

Expand All @@ -855,7 +855,7 @@ func (p *Program) recoverFromGoPanic(r interface{}) {
default:
}
p.cancel()
fmt.Printf("Caught goroutine panic:\n\n%s\n\nRestoring terminal...\n\n", r)
fmt.Printf("Caught goroutine panic:\n\n%s\n\nRestoring terminal...\n\n", r) //nolint:forbidigo
debug.PrintStack()
}

Expand Down