Extract accumulateStepCosts helper to remove duplicated logic - #3474
Open
traitimtrongvag wants to merge 1 commit into
Open
Extract accumulateStepCosts helper to remove duplicated logic#3474traitimtrongvag wants to merge 1 commit into
traitimtrongvag wants to merge 1 commit into
Conversation
…accumulation Assisted-by: Crush
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Summarize and GenerateTitle methods both iterate over provider step
metadata to accumulate OpenRouter costs and extract Hyper credits using
identical 12-line loop blocks. This change extracts the shared logic into
a single accumulateStepCosts helper method.
The refactoring is purely mechanical: the extracted code is identical in
both call sites, and the new helper is placed directly above the existing
openrouterCost method that it depends on. No behavior, signatures, or
imports are changed. The diff is -3 lines net, and the helper is
self-contained with no side effects beyond those already present in the
original duplicated blocks.