fix(ui): correct attachment overflow count and hint styling - #3516
Open
olifarhaan wants to merge 1 commit into
Open
fix(ui): correct attachment overflow count and hint styling#3516olifarhaan wants to merge 1 commit into
olifarhaan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "N more…" indicator was drawn after the chip it was meant to
replace, so the hidden count was always one too high, a single
attachment in a narrow pane reported "1 more…" with nothing hidden.
Fitting now happens before each chip is drawn and uses measured widths
rather than worst-case slots, so panes show as many chips as they hold.
Also renders the hint with the theme's foreground instead of a bare
style, which left it in the terminal's default color, and returns early
for non-positive widths where lipgloss ignores MaxWidth.
Fixes #3485"
CONTRIBUTING.md.I have read the Contributor License Agreement (CLA) and hereby sign the CLA.