test(config): stop inherited provider keys from failing the suite - #3526
Open
olifarhaan wants to merge 1 commit into
Open
test(config): stop inherited provider keys from failing the suite#3526olifarhaan wants to merge 1 commit into
olifarhaan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
go test ./internal/configfails if you have a Hyper key in your shell, and the failure diff prints that key to the terminalWhy it happened
TestRefreshOAuthToken_StalePeerBorrowsRotatedRefreshTokenrefreshes a token, and persisting it goes throughSetConfigFields, which auto-reloads. The reload resolvesHYPER_API_KEYfrom the environment and puts it back over the access token the refresh had just applied.CRUSH_HYPER_API_KEYbreaks it the same way, sincePushPopCrushEnv(load.go:182) copiesCRUSH_FOOoverFOOon every loadFix
TestMaindrops inherited*_API_KEYandCRUSH_*variables before running anything. Tests that need a credential keep setting one witht.SetenvCloses #3448
Proof
HYPER_API_KEYon its own reproduces it tooTests
TestInheritedCredentialEnvNamespins which names get dropped, including that aMALFORMEDentry andAPI_KEY_SUFFIXED_WRONGare left alone.TestMainClearedInheritedCredentialsasserts nothing survived into the test processgo test -race ./internal/config/...and golangci-lint v2.11 cleanThe issue also names two Venice tests, but neither exists on
mainanymore, so only the Hyper case still reproduces