fix(reasoning): if reasoning has ever been enabled loop back in#249
Open
taciturnaxolotl wants to merge 1 commit into
Open
fix(reasoning): if reasoning has ever been enabled loop back in#249taciturnaxolotl wants to merge 1 commit into
taciturnaxolotl wants to merge 1 commit into
Conversation
taciturnaxolotl
force-pushed
the
loop-reasoning-back-in
branch
from
9a9f485 to
6b629ad
Compare
andreynering
left a comment
andreynering
left a comment
Member
There was a problem hiding this comment.
Make sure to test this in Crush with many provider to ensure this doesn't break anything.
If we know which specific providers need this, we can also add a flag here and enable for these specifically.
taciturnaxolotl
force-pushed
the
loop-reasoning-back-in
branch
2 times, most recently
from
9ee4f8a to
32190f2
Compare
Member
Author
|
currently it just happens with kimi and deepseek on their openai compat apis |
Member
Author
|
i'm not sure the cleanest way to gate this to a provider doing it inline feels like a bad approach and making it another option also kind of feels like a bad approach |
taciturnaxolotl
force-pushed
the
loop-reasoning-back-in
branch
2 times, most recently
from
18cd420 to
61b0d0a
Compare
Member
Author
|
what makes this especially complicated is that this wasn't using a catwalk provider but rather a user openai-compat provider which makes the provider id non deterministic |
taciturnaxolotl
force-pushed
the
loop-reasoning-back-in
branch
from
61b0d0a to
985af22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should fix charmbracelet/crush#2696; when reasoning is enabled on deepseek or kimi in their openai compat modes if it is then disabled but was ever enabled in the first place, they require reasoning content on all tool calls and messages
Fixes CHARM-1395