test: add tests for thinking#9
Merged
kujtimiihoxha merged 6 commits intomainfrom Sep 18, 2025
Merged
Conversation
andreynering
force-pushed
the
charm-599-gemini-initial-implementation
branch
3 times, most recently
from
286478a to
c69bc6b
Compare
Base automatically changed from
charm-599-gemini-initial-implementation
to
main
September 16, 2025 13:19
kujtimiihoxha
force-pushed
the
thinking-tests
branch
from
569acac to
1b5f04b
Compare
- add chrush.md - add check to google provider - make all tests use testify
kujtimiihoxha
changed the title
andreynering
commented
Sep 17, 2025
| } | ||
| } | ||
|
|
||
| func testThinkingSteps(t *testing.T, providerName string, steps []ai.StepResult) { |
Member
Author
There was a problem hiding this comment.
3 simple suggestions for a cleaner test code here.
- Create a
thinking_test.gofile to hold these thinking helpers. - Have separate functions for provider:
testThinkingAnthropic,testThinkingOpenAi, etc. - On the main func, use a
switchinstead of multipleif/else:
func testThinkingSteps(t *testing.T, providerName string, steps []ai.StepResult) {
switch providerName {
case anthropic.Name:
testThinkingStepsAnthropic(t, providerName, steps)
case openai.Name:
testThinkingStepsOpenAi(t, providerName, steps)
default:
// ???
}
}
Contributor
|
Will merge this in and add tests as we go |
hugodutka
pushed a commit
to hugodutka/fantasy
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(just testing gh connection for DevStride)