fix(ansi): rendering for HTML <img> tags#546
Open
Zvorky wants to merge 2 commits intocharmbracelet:mainfrom
Open
fix(ansi): rendering for HTML <img> tags#546Zvorky wants to merge 2 commits intocharmbracelet:mainfrom
Zvorky wants to merge 2 commits intocharmbracelet:mainfrom
Conversation
Parse <img src alt> in KindHTMLBlock and KindRawHTML nodes and route them through ImageElement, matching the behaviour of Markdown . Code blocks containing <img> are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.Parse
<img src alt>in KindHTMLBlock and KindRawHTML nodes and routethem through ImageElement, matching the behaviour of Markdown
.Code blocks containing
<img>are unaffected.I also added an automated test in
tests/and examples instyles/examples/in a commit prior to the fix for easier reproduction.