Skip to content

fix: disallow 'h' key when was pipeline #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: disallow 'h' key when was pipeline #687

wants to merge 3 commits into from

Conversation

Shane-XB-Qian
Copy link
Contributor

    1. if pager was 'less' then 'h' was its native 'help'
    1. if pager was 'tui' then seems no sense 'h' to back

@Shane-XB-Qian Shane-XB-Qian requested a review from a team as a code owner February 13, 2025 12:57
@Shane-XB-Qian Shane-XB-Qian requested review from andreynering and removed request for a team February 13, 2025 12:57
@Shane-XB-Qian
Copy link
Contributor Author

  1. test err of ruleguard, the fix had committed at fix: gave prompt when/if content was empty #686
  2. test err of coverage, seems a ci network issue, not relevant.

@Shane-XB-Qian
Copy link
Contributor Author

maybe should also disable 'h' when 'glow -t foo.md' which seems mostly for md watch,
for now in such case even emit 'h' it would not be nice back to md list (from md doc), a bit abnormal.

@Shane-XB-Qian
fix: disallow 'h' key when was pipeline
c98050b 
* 1. if pager was 'less' then 'h' was its native 'help'
* 2. if pager was 'tui' then seems no sense 'h' to back

Signed-off-by: shane.xb.qian <[email protected]>
@Shane-XB-Qian
fix: let 'h' work only when arg was file
e8aff06 
Signed-off-by: shane.xb.qian <[email protected]>
@Shane-XB-Qian Shane-XB-Qian force-pushed the fix_disallow_h_when_pipeline branch from bd6238a to e8aff06 Compare February 14, 2025 13:44
@Shane-XB-Qian
ci: some flaky at ruleguard
20c789b 
Signed-off-by: shane.xb.qian <[email protected]>
@Shane-XB-Qian
Copy link
Contributor Author

maybe should also disable 'h' when 'glow -t foo.md' which seems mostly for md watch, for now in such case even emit 'h' it would not be nice back to md list (from md doc), a bit abnormal.

i have fixed such cases, please review if ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreynering andreynering Awaiting requested review from andreynering andreynering is a code owner automatically assigned from charmbracelet/everyone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Shane-XB-Qian