fix: handle UTF-16 LE/BE encoded files with BOM #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UTF-16 encoded files were not being rendered correctly because the raw bytes were directly converted to strings without encoding detection. This adds a ToUTF8String utility function that: - Detects UTF-16 LE BOM (0xFF 0xFE) and converts to UTF-8 - Detects UTF-16 BE BOM (0xFE 0xFF) and converts to UTF-8 - Strips UTF-8 BOM (0xEF 0xBB 0xBF) if present - Falls back to treating content as UTF-8 if no BOM detected The function is now used in all file reading paths: - CLI mode (main.go) - TUI document view (ui/ui.go) - TUI stash/file browser (ui/stash.go) Fixes charmbracelet#513 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
majiayu000
requested review from
andreynering and
raphamorim
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513
Changes
ToUTF8String()utility function to detect and convert UTF-16 LE/BE with BOM to UTF-8