fix: Using a custom style with conceal:true does not hide element #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue charmbracelet#645 where setting `conceal: true` on the `link` element in a custom style JSON file did not hide the URL portion of links. The fix is implemented in the glamour library (included as _glamour) by modifying the link element creation in elements.go to check the Link.Conceal style property and set SkipHref accordingly. When Link.Conceal is true, only the link text is rendered without the URL. Example custom style: ```json { "link": { "conceal": true } } ``` Note: This includes a patched copy of glamour. Once the fix is merged upstream to charmbracelet/glamour, the _glamour directory can be removed and the replace directive in go.mod updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
majiayu000
requested review from
kujtimiihoxha and
tauraamui
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
Changes
conceal: trueis set in custom style's link element, the URL portion is now hiddenStyles.Link.Concealin both regular links and auto-links to setSkipHref = true